feat: add message for empty charts #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickskowronekdkfz
requested changes
Jan 15, 2025
| @@ -391,15 +394,23 @@ | |||
| * @param responseStore - the response store | |||
| */ | |||
| const setChartData = (responseStore: ResponseStore): void => { | |||
| if (responseStore.size === 0) return; | |||
| if (responseStore.size === 0) { | |||
There was a problem hiding this comment.
The logic is not correct, when the responseStore is empty it should be the "empty charts" look like the initial load. If the Store has results but not regarding this Diagramm then it should show the text
| @@ -589,6 +600,11 @@ | |||
| {#if options.hintText} | |||
| <InfoButtonComponent message={options.hintText} /> | |||
| {/if} | |||
|
|
|||
| {#if noDataAvailable} | |||
| <p>No Data Available</p> | |||
There was a problem hiding this comment.
Could you make it less aggressive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Summary
Description
Added a "No Data available" message when the chart contains no data. The message is rendered in the chart when all dataset values are 0 or empty
Related Issue
#160 (comment)