Modify DKTK_Strat_SPECIMEN to improve the search more sample centric #163
Conversation
|
When changing DKTK CQL, please also add @thkoehler11 as a reviewer. |
|
Would you also be so kind to copy all the DKTK CQL snippets in preparation for CQL generation in Focus, as I explained in the Focus chat? |
patrickskowronekdkfz
force-pushed
the
feat/specimen_improved_search
branch
from
f812bd2 to
86c79d3
Compare
|
I can't review CQL changes, so I requested reviews from @thkoehler11 and @enola-dkfz |
|
I do not know the requirements of DKTK, so I am letting Thomas review the CQL. I can only confirm that this change will not break focus in general, and might only cause unwanted behaviour in DKTK. |
|
@patrickskowronekdkfz will update this PR with some additional specimen related CQL changes, I will review after that. |
This PR should be converted to draft then so that someone doesn't accidentally merge it. |
|
@thkoehler11 please re-review the PR. Now contains the FFPE samples as well |
patrickskowronekdkfz
force-pushed
the
feat/specimen_improved_search
branch
from
f349f94 to
828134f
Compare
This PR introduces a new stratifier for DKTK sample-specific search, while keeping the existing stratifier intact to ensure backwards compatibility.
This feature needs to be merged in Lens as well, with PR samply/lens#163.
This was tested locally with a lens+spot+beam+focus+blaze setup and with our test server.