Pin typescript to @4.4.4 to fix CI (grpc#1170)

sampajano · Nov 18, 2021 · f1d863f · f1d863f
1 parent 9f76a56
commit f1d863f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.dockerignore b/.dockerignore
@@ -1,2 +1,3 @@
+**/dist
 **/node_modules
 packages/grpc-web/generated
diff --git a/net/grpc/gateway/docker/ts_client/Dockerfile b/net/grpc/gateway/docker/ts_client/Dockerfile
@@ -14,8 +14,6 @@
 
 FROM grpcweb/prereqs
 
-RUN npm install -g typescript
-
 WORKDIR /github/grpc-web/net/grpc/gateway/examples/echo
 
 RUN protoc -I=. echo.proto \
@@ -26,7 +24,7 @@ WORKDIR /github/grpc-web/net/grpc/gateway/examples/echo/ts-example
 
 RUN npm install && \
   npm link grpc-web && \
-  tsc && \
+  npx tsc && \
   npx webpack && \
   cp echotest.html /var/www/html && \
   cp dist/main.js /var/www/html/dist

diff --git a/net/grpc/gateway/examples/echo/ts-example/package.json b/net/grpc/gateway/examples/echo/ts-example/package.json
@@ -1,12 +1,13 @@
 {
-  "dependencies": {
+  "devDependencies": {
     "@types/google-protobuf": "~3.7.0",
     "@types/jquery": "~3.3.6",
     "@types/node": "~10.17.0",
     "google-protobuf": "~3.14.0",
     "grpc-web": "~1.3.0",
     "jquery": "~3.5.1",
     "mock-xmlhttprequest": "~2.0.0",
+    "typescript": "~4.4.4",
     "webpack": "~4.43.0",
     "webpack-cli": "~3.3.11"
   }

diff --git a/packages/grpc-web/package.json b/packages/grpc-web/package.json
@@ -37,6 +37,6 @@
     "mocha": "~5.2.0",
     "mock-xmlhttprequest": "~2.0.0",
     "protractor": "~7.0.0",
-    "typescript": "~3.8.0"
+    "typescript": "~4.4.4"
   }
 }