Add translation keys and usage #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why don't you rebase instead of revert or merge? |
|
This was the first thing that came to mind haha. Does rebasing get tracked? |
|
rebasing reapplies your commits on top of the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository uses ember-intl thus the yaml file can hold the translation keys for localization., like what was changed here with the en-us.yaml file.
You can add a new localalization file and set the locale within the www/app/routes/application.js.
I've only added a few keys to the localization file, but to translate the rest, other keys must be added with the desired text in the proper localization file and the template pages need to be edited to use them.
Issues:
#397
#199