Skip to content

Adding "next" redirect #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ This document assumes that you are familiar with Python and Django.

TEMPLATE_DIRS = (
...
'path/to/persistent_messages/templates')
'path/to/persistent_messages/templates'
)


Expand Down
7 changes: 7 additions & 0 deletions persistent_messages/storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from django.contrib.messages.storage.fallback import FallbackStorage
from django.db.models import Q
import datetime
import itertools

def get_user(request):
if hasattr(request, 'user') and request.user.__class__ != AnonymousUser:
Expand Down Expand Up @@ -77,6 +78,12 @@ def __iter__(self):
messages.extend(self._queued_messages)
return iter(messages)

def __getitem__(self, index):
try:
return next(itertools.islice(self.__iter__(), index, index + 1))
except TypeError:
return list(itertools.islice(self.__iter__(), index.start, index.stop, index.step))

def _prepare_messages(self, messages):
if not get_user(self.request).is_authenticated():
return super(PersistentMessageStorage, self)._prepare_messages(messages)
Expand Down
6 changes: 4 additions & 2 deletions persistent_messages/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ def message_mark_read(request, message_id):
message.read = True
message.save()
if not request.is_ajax():
return HttpResponseRedirect(request.META.get('HTTP_REFERER') or '/')
return HttpResponseRedirect(
request.REQUEST.get("next", request.META.get('HTTP_REFERER')) or '/')
else:
return HttpResponse('')

Expand All @@ -33,6 +34,7 @@ def message_mark_all_read(request):
raise PermissionDenied
Message.objects.filter(user=user).update(read=True)
if not request.is_ajax():
return HttpResponseRedirect(request.META.get('HTTP_REFERER') or '/')
return HttpResponseRedirect(
request.REQUEST.get("next", request.META.get('HTTP_REFERER')) or '/')
else:
return HttpResponse('')