Add default date schema option #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for the PR! This looks good from an initial look, I'll take a closer look this week! |
samchungy
approved these changes
Oct 7, 2024
|
Thanks for your contribution! I'll look to do a release tomorrow once I've sat on the changes for a bit :) |
|
Thank you for your confirmation and merge! 😆 I am very happy because this feature is important to me. Thanks, samchungy🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #305
Hi samchungy.
I have added a feature that resolves #305.
Added an options object argument to createDocument function to allow setting the value of
defaultDateSchema.After the SchemaState object is created, it is passed to each function by passing an options object to SchemaState object.
If you see any problems or shortcomings, please point them out to me.