-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for the docker method and no need of VNC viewer #109
base: master
Are you sure you want to change the base?
Conversation
Updated docker file that works. Node12 wasn't in support anymore and changed and upgraded some of the apt modules for docker containers
Updated README.md
Update Dockerfile
Added a docker env file which DB Username and Password to bypass the entire making database process
Created .env.docker
Poorly edited but has all the instructions to get someone started with the bot with no knowledge.
Update README.md
Hi @brikjr thanks for this PR. The use of the VNC Viewer is certainly not a requirement, it is just an option for users who want to launch the browser with If we are going to update the Node version for Docker, it should definitely be done using the Node LTS version (currently v18.17.1). Using Node 16 wouldn't make sense as it's going to leave the maintenance phase imminently. @meh-me submitted #102 for Node 18 but I ran into some issues when trying to run it from my end. Could you try running it from your end? If it works, I'm more inclined to merge that PR and then we can separately address your other suggested changes. Thanks! |
I tried all the Node versions keeping it up to date is important. Node 16 works the best with all the requirements that you need. Node 12, 14, 16 and 18 were the versions I tried. Please let me know if I can do something else |
@brikjr thanks, could you specify what issue you encountered specifically with Node 18? Preferably with a stack trace if possible and/or minimal steps to reproduce the error? I'd be happy to investigate it. I have a strong preference for using the LTS version if we can. |
Unfortunately I do not have the bandwidth lately to work on it. I used this bot as it had a shopify support but the new Supreme website works differently than the majority of shopify sites, I did make the bot work but wasn't really fruitful. So, I am kind of out of touch lately. I will try my best. Thanks |
Poorly edited readme but has all the instructions to get someone started with the bot with no knowledge.