Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rhel support to rpm builds #135

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

andrewschoen
Copy link
Contributor

I've been using this patch on an entitled rhel9 node, with epel installed. Calling the script like this does produce a build.

export SAMBACC_BUILD_TASKS="task_sys_deps task_py_build task_rpm_build"
export SAMBACC_BUILD_DIR=/tmp/sambacc-build
export SAMBACC_DISTNAME=rhel9
export SAMBACC_REPO_URL="https://github.com/ibmstorage/sambacc"

sh sambacc/tests/container/build.sh

phlogistonjohn
phlogistonjohn previously approved these changes Aug 30, 2024
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @andrewschoen !

The change itself looks good to me but the ci complains about the commit message title: I think it is missing a category/component.

Please fix!

@mergify mergify bot dismissed phlogistonjohn’s stale review August 30, 2024 15:42

Pull request has been modified.

@andrewschoen
Copy link
Contributor Author

Thanks for this PR, @andrewschoen !

The change itself looks good to me but the ci complains about the commit message title: I think it is missing a category/component.

Please fix!

Sure thing, I have that fixed now.

Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the commit/ should be good now.

LGTM

@mergify mergify bot merged commit 7b361bf into samba-in-kubernetes:master Aug 30, 2024
9 checks passed
@andrewschoen andrewschoen deleted the wip-rhel-rpms branch September 5, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants