This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
Push image #97
Open
Push image #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age-merge Conflicts: interface.go types.go
Push image merge
|
@divideandconquer Thanks for your contribution! do you have time to rebase this? we'd like this functionality, so if you don't have time I can take this over |
Merged
| defer resp.Body.Close() | ||
| var finalObj map[string]interface{} | ||
| for decoder := json.NewDecoder(resp.Body); err == nil; err = decoder.Decode(&finalObj) { | ||
| } |
There was a problem hiding this comment.
was this meant to go after line 515?
There was a problem hiding this comment.
no. this loop gets the final object in the json stream
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also contains the BuildImage functionality from #85 Merge #85 First to see a better diff.
PushImage will take an image name, tag, and optional authentication configuration and push that image to an image repository e.g. https://quay.io/