This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
Add a blocking get stats interface #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| uri := fmt.Sprintf("%s/%s/containers/%s/stats", client.URL.String(), APIVersion, id) | ||
| resp, err := client.HTTPClient.Get(uri) | ||
| if err != nil { | ||
| errorChan <- ContainerError{Error: err, ContainerId: id} |
There was a problem hiding this comment.
I agree with the errorChan when the stats stream is open, but should we use an error code return for opening the stream (and check this http req)?
I am not sure about this one (what's the easiest for the dev), it's an honest question. Also, tests?
|
Yeah I'm not sure either. When I added the original implementation I was thinking along the lines of the event stream which handles things that way (callback). +1 for stopping events for a single container. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - I am working on an application that consumes the dockerclient api! (woot) Specifically I am working with the stats API. The implementation of the stats API in this library and great and seems well suited for short lived client application. I am writing a daemon that will monitor the stats and have some additional requirements that don't seem to work well with the current implementation.
errorand the container ID that it is related to.Thoughts?