[3007.x] Fix minion config option startup_states

[transistortim]

What does this PR do?

The changes in this PR fix #66592 by making additional functions use async/await.

What issues does this PR fix or reference?

Fixes #66592

Previous Behavior

11a06ce made some internal functions async. This broke functions calling these internal functions without await. This leads to the minion configuration option startup_states not working any more.

New Behavior

Starting the minion with startup_states now works as expected.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

No. Is this required?

Note

Making more functions async might have introduced some more bugs I didn't catch yet. Specifically I've never used ProxyMinions and Syndic, maybe somebody with more experience could look into that.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on LiberaChat
• Salt Project YouTube channel
• Salt Project Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[twangboy]

This should probably be made against 3007.x branch. Would you mind rebasing this PR?

[transistortim]

Thanks for the review! I'm currently on vacation, I'll take care of it when I get back (around June 24).

[73VW]

Hey @transistortim any update on this?

Thanks

[transistortim]

Sorry for the delay, I was busy with some other things. Finally, here's the update :)

[amalaguti]

Will this fix be made available for 3007.2 ?

[twangboy]

Looks like there is a lint failure. Would you mind taking a look?
Also, there are some test failures.

[amalaguti]

Looks like there is a lint failure. Would you mind taking a look? Also, there are some test failures.

Shane,
found this in the CI pipeline

************* Module salt.minion
salt/minion.py:3879: [W0236(invalid-overridden-method), ProxyMinion.tune_in] Method 'tune_in' was expected to be 'async', found it instead as 'non-async'

Today I worked on another two issues related to async/await and also the tune_in() (the main tune_in in minion class).
Looks like it's all related.
#66932
#67016