Moving deltaproxy code into Salt open #60090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
suggested changes
Apr 30, 2021
s0undt3ch
suggested changes
May 1, 2021
garethgreenaway
changed the title
3 tasks
Ch3LL
suggested changes
Jul 6, 2021
Ch3LL
previously approved these changes
Jul 7, 2021
Ch3LL
previously approved these changes
Jul 13, 2021
s0undt3ch
suggested changes
Jul 14, 2021
…fined in the proxy configuration file. Updating tests.
…pdate tests to test both dummy proxy minions. Make dummy proxy minion work better with deltaproxy by having each instance use it's own cache file.
…d test_simple.py.
…the value passed in.
…xt__ instead of global variables.
…port from napalm.base instead of napalm_base, unable to import from an import alias.
…uring that we are looking for the right alive function in the appropriate proxy minion.
…name since we use the value in the if statement and later when starting up the proxy.
garethgreenaway
force-pushed
the
adding_deltaproxy
branch
from
be3ea3e to
f957b3c
Compare
|
@garethgreenaway is this ready for re-review? |
|
@Ch3LL I wasn't sure if @s0undt3ch had any additional reviews he was working through on this particular PR. |
|
Yes, i should finish my review... |
dwoz
approved these changes
Aug 24, 2021
garethgreenaway
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously the deltaproxy code was only available as an enterprise only product, this PR is moving the deltaproxy code into Salt open
Fixes #60177 #60581
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.