-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(platform): add arch-base-latest
& split suites across Travis instances
#43
ci(platform): add arch-base-latest
& split suites across Travis instances
#43
Conversation
a8d4176
to
11af24c
Compare
@dafyddj Another issue that could be covered at the same time:
|
eb7a407
to
6c73c5c
Compare
9907631
to
6dd656f
Compare
@dafyddj So I've prepared a comparison, before and after splitting the suites across the various instances:
The differences are significant. If you're OK with it, I'll add that to this PR. |
arch-base-latest
arch-base-latest
& split suites across Travis instances
@dafyddj I've added the commit to split the suites in Travis, so this is ready for review. |
* Automated using myii/ssf-formula#45
* Automated using myii/ssf-formula#45 * Current tests are resulting in `undefined method` errors with `4.17.7`: - https://travis-ci.com/saltstack-formulas/vault-formula/jobs/239671364#L2219-L2220 - https://travis-ci.com/saltstack-formulas/vault-formula/jobs/239671365#L1925-L1926 - https://travis-ci.com/saltstack-formulas/vault-formula/jobs/239671366#L1515-L1520
f6762a6
to
c82034a
Compare
@dafyddj There's bad news on the horizon. As I thought I was done with this PR, all of the instances started failing (when they were working fine in my fork yesterday). Dug down and found out that the latest A summary of the errors avoided (for the time being): https://travis-ci.com/saltstack-formulas/vault-formula/jobs/239671364#L2219-L2220 ( >>>>>> Failed to complete #verify action: [undefined method `file' for #<#<Class:0x000055dca642a3c8>:0x000055dca642a2d8>
Did you mean? fail] on prod-server-ubuntu-1804-2019-2-py3 https://travis-ci.com/saltstack-formulas/vault-formula/jobs/239671365#L1925-L1926 ( >>>>>> Failed to complete #verify action: [undefined method `file' for #<#<Class:0x000055cdc9bcb5f0>:0x000055cdc9bd26e8>
Did you mean? fail] on dev-server-fedora-30-2019-2-py3 https://travis-ci.com/saltstack-formulas/vault-formula/jobs/239671366#L1515-L1520 ( × should not be installed
undefined method `sysv_service' for #<#<Class:0x0000558e533124a0>:0x0000558e533340a0>
× should not be enabled
undefined method `sysv_service' for #<#<Class:0x0000558e533124a0>:0x0000558e533340a0>
× should not be running
undefined method `sysv_service' for #<#<Class:0x0000558e533124a0>:0x0000558e533340a0> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WRT splitting the suites, prod_server
is really the important test suite. The other two test suites mainly test formula logic so only really need running once. I've made some suggested changes to that effect.
Other than that, happy with it, and thanks for helping to improve the formula 👍🏻
Co-Authored-By: Dafydd Jones <[email protected]>
@dafyddj Thanks for the review, I've committed the suggestions as a batch. Now due to these repo's settings (as outlined in #45), we can't merge this because of an org-wide issue we're currently having with |
🎉 This PR is included in version 1.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [1.8.0](v1.7.0...v1.8.0) (2019-10-01) ### Features * **vault:** limit commented instances to empty suite ([eee355b](eee355b)) * **vault:** split suites across instances leaving one running all ([e7483a3](e7483a3)), closes [/github.com/saltstack-formulas/vault-formula/pull/43#issuecomment-533936364](https://github.com//github.com/saltstack-formulas/vault-formula/pull/43/issues/issuecomment-533936364) * **vault:** use specific Gemfile to restrict `inspec` version ([a9b7ff9](a9b7ff9)) * **vault): ci(travis:** apply suggestions from code review ([54ea2fb](54ea2fb))
arch-base-latest
myii/ssf-formula#40 and feat(vault): split suites across instances leaving one running all myii/ssf-formula#45