Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SALTO-6367: Adjust migrated MFA policies to Identity Engine format in Okta #6353

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shir-reifenberg
Copy link
Contributor

@shir-reifenberg shir-reifenberg commented Aug 6, 2024

Adjust MFA policies on identity engine accounts during fetch


Additional context for reviewer

The change is needed in order to -

  1. Parse references correctly to authenticators (currently the string to reference for was a map key, so I switched it to value)
  2. The nacl at its current state is not deployable for Identity Engine accounts, because the Okta API expect it to be in the AUTHENTICATORS format

Release Notes:
Replace me with a short sentence that describes changes that will appear in NaCls and are not caused by user actions (e.g. a new annotation, field values that are converted to references, etc). Hidden changes should not be listed.


User Notifications:
Replace me with a short sentence that describes changes that will appear in NaCls and are not caused by user actions (e.g. a new annotation, field values that are converted to references, etc). Hidden changes should not be listed.

@coveralls
Copy link

Coverage Status

coverage: 93.773% (+0.02%) from 93.751%
when pulling d0754db on shir-reifenberg:SALTO-6367-AlignMfaEnrollmentTypes
into 74a38c9 on salto-io:main.

Copy link
Contributor

@omrifarkash omrifarkash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand why is this change needed. I find the old code of excluding types from the definitions more readable and yield the same results?

Lets talk f2f :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants