Fix metdata password for cluster and containers #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were three ways the deafult for this parameter was defined:
cluster:
password: metadataPass
container:
password: ${_param:nova_metadata_password}
single:
password: ${_param:metadata_password}
Between "nova_metadata_password" and "metadata_password",
"metadata_password" seems better because this password is intentionally
shared between nova and neturon, and it should not be different between
the two. Standardize all three service roles to use the same default.
|
This pull request is a simple bugfix; it makes nova consistent with neutron ( https://github.com/salt-formulas/salt-formula-neutron/blob/master/metadata/service/gateway/single.yml#L22 ). Can someone please review and let me know if there's something else I should do for this request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three ways the deafult for this parameter was defined:
cluster:
password: metadataPass
container:
password: ${_param:nova_metadata_password}
single:
password: ${_param:metadata_password}
Between "nova_metadata_password" and "metadata_password",
"metadata_password" seems better because this password is intentionally
shared between nova and neturon, and it should not be different between
the two. Standardize all three service roles to use the same default.