Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip-connection-status flag works #777

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Aug 16, 2023

What does this PR do?

we've been ignoring --skip-connection-status since this command was sf-ified. Flags weren't typed before.

What issues does this PR fix or reference?

@W-13957953@

@mshanemc mshanemc added the bug Something isn't working label Aug 16, 2023
@git2gus
Copy link

git2gus bot commented Aug 16, 2023

This issue has been linked to a new work item: W-13957953

@shetzel
Copy link
Contributor

shetzel commented Aug 17, 2023

QA:
Without fix, connectionStatus is reported in the JSON output for sf org list --skip-connection-status --json
With fix, connectionStatus is NOT reported in the JSON output for .../plugin-org/bin/dev org list --skip-connection-status --json

@shetzel shetzel merged commit 92cc87d into main Aug 17, 2023
12 checks passed
@shetzel shetzel deleted the sm/restore-skip-connection-status branch August 17, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants