Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm/sandboxes-in-list #765

Merged
merged 9 commits into from
Aug 9, 2023
Merged

Sm/sandboxes-in-list #765

merged 9 commits into from
Aug 9, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Aug 4, 2023

What does this PR do?

well, this started off as "make sandboxes a section within org:list" (we can do that more reliably now thanks to Steve's PR for identifying them)

also, while I was in here, I realized how ugly that table is. So

  1. remove all the extra ASCII characters.
  2. default markers (U) and (D) don't mean anything and don't even align with flags anymore. Those are now emojis and there's a legend at the bottom of the table. If you've got better emojideas, holler.
  3. One table so the columns align
  4. Type field (DevHub, Sandbox, Scratch Org, ?) [the original WI]
  5. colors by type, orgs are grouped by those types
  6. aliases are at the top of their section instead of the bottom
  7. instanceUrl appears when --verbose for non-scratch orgs, too
  8. long datestamp for createdDate is now just yyyy-mm-dd to match ExpirationDate
  9. Column headers are title case instead of UPPERCASE

No JSON should be harmed in the making of this PR

What issues does this PR fix or reference?

@W-10983482@

src/commands/org/list.ts Outdated Show resolved Hide resolved
src/commands/org/list.ts Outdated Show resolved Hide resolved
src/commands/org/list.ts Outdated Show resolved Hide resolved
@WillieRuemmele
Copy link
Contributor

QA Notes


✅ : everything demo'd in demos
✅ : don't have a sandbox - saw it colored and delineated in demos
✅ : --clean / --all / --no-prompt behavior
✅ : emojis in terminal/macOS at least 🤷‍♂️
🏆 : colors
🏆 : aliases first
🏆 : less cluttered table
🏆 : more consistent formats
✅ : --json behavior

 ➜  sfdx org:list --all --json | jq -r '.result.nonScratchOrgs | length'
2
➜  dreamhouse-lwc git:(main) ✗  hub:(DevHub) scratch:([email protected])
 ➜  ../../oss/plugin-org/bin/dev org:list --all --json | jq -r '.result.nonScratchOrgs | length' 
2

@WillieRuemmele WillieRuemmele merged commit b03da3c into main Aug 9, 2023
11 checks passed
@WillieRuemmele WillieRuemmele deleted the sm/sandboxes-in-list branch August 9, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants