Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sl/w 16972747 #1257

Merged
merged 11 commits into from
Nov 13, 2024
Merged

Sl/w 16972747 #1257

merged 11 commits into from
Nov 13, 2024

Conversation

soridalac
Copy link
Contributor

What does this PR do?

fix: prevent delete sandbox as default when using org delete scratch

What issues does this PR fix or reference?

@W-16972747@

Github issue link: forcedotcom/cli#3058

@soridalac soridalac requested a review from a team as a code owner November 6, 2024 21:04

# error.unknownScratch

The org with username: %s is not known by the CLI to be a scratch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The org with username: %s is not known by the CLI to be a scratch
The org with username %s isn't a scratch org.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soridalac , okay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, how about:

Unable to find a scratch org with username %s.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay thats work, I will change it.

@cristiand391
Copy link
Member

QA notes:

✅ throws on non-scratch orgs
✅ deletes valid scratch org usernames

@cristiand391 cristiand391 merged commit 0b33f16 into main Nov 13, 2024
11 checks passed
@cristiand391 cristiand391 deleted the sl/W-16972747 branch November 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants