Md file link for diagnostic #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const extensionTitle = | ||
| context.extension.packageJSON.contributes.configuration.title; | ||
|
|
||
| const diagnosticBaseRootUrl = `${repository.url}/blob/v${version}/src/lsp/docs`; |
There was a problem hiding this comment.
get the lsp doc md file root url and pass to lsp server.
ben-zhang-at-salesforce
changed the title
ben-zhang-at-salesforce
changed the title
haifeng-li-at-salesforce
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clive finished the md file writeup in this merged pr. here we updated the code to point to the md file when diagnostic is rendered over mouse over.
It looks like below and now it matches what eslint plugin reported problems for vscode now :)
