Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename test fixtures #5177

Merged
merged 1 commit into from
Jan 30, 2025
Merged

chore: rename test fixtures #5177

merged 1 commit into from
Jan 30, 2025

Conversation

wjhsf
Copy link
Collaborator

@wjhsf wjhsf commented Jan 30, 2025

Some of the directory names were too sentence-y, which made them annoying to work with.

List of new names, since the diff isn't helpful
adapter-function-identifier-works
adapter-member-expression-works
basic-field
basic-method
config-ignores-method
config-ignores-spread
config-imported-values-works
config-multiple-dynamic-params-works
config-not-provided-works
config-numeric-keys-works
config-string-literal-keys-works
decorating-multiple-props-works
decorator-on-getter-alone-works
decorator-on-getter-works
decorator-on-setter-alone-works
decorator-on-setter-works
reactive-string-2-levels-works
reactive-string-deep-chain-works
reactive-string-with-empty-segment-works
reactive-string-with-non-identifier-works
throws-on-2-wires
throws-on-adapter-computed-prop
throws-on-adapter-function-expression
throws-on-adapter-local-var
throws-on-adapter-nested-member-expression
throws-on-adapter-undeclared-var
throws-on-config-not-object
throws-on-decorator-no-args
throws-on-wired-method-with-@api
throws-on-wired-prop-with-@api
throws-on-wired-prop-with-@track
throws-when-computed-prop-is-expression
throws-when-computed-prop-is-let-variable
throws-when-computed-prop-is-regexp-literal
throws-when-computed-prop-is-template-literal
transforms-computed-properties
transforms-computed-properties-const-from-obj

I didn't update the computed prop names because I'm planning on changing them anyway in my next PR.

Details

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

some of the directory names are too sentence-y
@wjhsf wjhsf requested a review from a team as a code owner January 30, 2025 17:01
@wjhsf wjhsf enabled auto-merge (squash) January 30, 2025 19:53
@wjhsf wjhsf merged commit 1c546b1 into master Jan 30, 2025
11 checks passed
@wjhsf wjhsf deleted the wjh/rename-tests branch January 30, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants