Update to Spark 2.4.3 + XGBoost 0.90 + MLeap 0.14 #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=========================================
+ Coverage 86.68% 86.79% +0.1%
=========================================
Files 336 336
Lines 10821 10895 +74
Branches 359 562 +203
=========================================
+ Hits 9380 9456 +76
+ Misses 1441 1439 -2
Continue to review full report at Codecov.
|
… made to decision tree pruning in Spark 2.4. If nodes are split, but both child nodes lead to the same prediction then the split is pruned away. This updates the test so this doesn't happen for feature 'b'
|
LGTM |
wsuchy
approved these changes
May 31, 2019
gerashegalov
approved these changes
Jun 3, 2019
features/src/main/scala/com/salesforce/op/utils/spark/RichDataset.scala
Outdated
Show resolved
Hide resolved
tovbinm
changed the title
|
LGTM |
leahmcguire
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
We would like to use XGBoost 0.90, but it requires Spark 2.4.x and also #184
Describe the proposed solution
PredictionModel.predict(since 2.4 - [SPARK-10884][ML] Support prediction on single instance for regression and classification related models apache/spark#19381)spark-avrodependency (since avro support is included with spark)Describe alternatives you've considered
NA