Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

fix to continue function #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arthurprevot
Copy link

Ran into an issue when loading the next batch of 2500 records from a SOAP API retrieve operation. The first batch was fine but the 2nd one, i.e. the first one using the continue method, was not, sending back a message with a status labelled as Error. The problem was documented in http://salesforce.stackexchange.com/questions/24911/error-on-making-continue-request-while-retrieving-all-subscribers-from-a-list. This PR implements that fix since it solved the issue for me as well.

@ses4j
Copy link

ses4j commented Oct 21, 2015

Pulled this in to fix FuelSDK::Subscriber, now getResults.continue "works". However, it seems to append the new results to the old results, so:

results = subscriber.continue
results.length == 5000 after page 2...
results.length == 7500 after page 3...

Copy link

@Gokul595 Gokul595 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the issue in continue method.

@Ksm125
Copy link

Ksm125 commented May 19, 2021

we should also have in the unpack method

@results = (unpack_rslts raw)

instead of

@results += (unpack_rslts raw)

to not overflow the memory

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants