Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10496 - Prevent password autofill when setting up emails #10497

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

Description

This PR resolves this issue by preventing autocompletion by adding the autocomplete='new-password' property to the password type field.

Motivation and Context

#10496

How To Test This

  1. Access the Email Settings and save a first configuration with a password. At the same time, save the password in the browser (After clicking on save the record, a dialog box is usually displayed to save the user and password in the browser)
  2. Acces again in Email Settings, click en "Change Password" and check that password stored in the browser is not recovered in password field. Check that the send test email runs correctly
  3. Go to the Outbound Email module and access the editing view of the system record. Check that the password stored in the browser is not recovered in the password field. Check that the send test email runs correctly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,
thanks for your PR!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Area: Emails Issues & PRs related to all things regarding emails & email module Branch:Hotfix PR 4-8 Score given to PRs once assessed labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Emails Issues & PRs related to all things regarding emails & email module Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants