Fix #9261 - Use decimal symbol configured in system and user

[SinergiaCRM]

Description

This PR fixes the decimal separator symbol for a decimal or float value obtained from a database not being parsed correctly when incorporated into an email template or PDF template.

To do this, a generic function is created in the PR with a parameter where you can indicate which configuration to use: the system configuration (configured by default) or the user configuration. This function will be used in the operation of parsing the PDF template or the email template.

Our proposal is to use the system configuration for sending emails and the user configuration for using the PDF template.

Motivation and Context

• User-configured decimal symbol separator is not used in Templates #9261
• We have found that this also happens when sending an email from a workflow. Here is a video with the three use cases of incorrect behavior.

How To Test This

1. Create a decimal and a float fields in a contact module

2. Set a symbol to separate decimals in user profile and system configuration.

3. Create a contact-based email template that contains the decimal and float fields.

4. Create a campaign and use the previous template.

5. Send a email and check that in the sent email, the decimal and float values is being parsed with the configured system decimal symbol

6. Create a workflow based on Contacts and edit a Contact that has a value in the decimal and float fields for the workflow to send the email with the previous template

7. Check that in the sent email, the decimal and float value is being parsed with the configured system decimal symbol

8. Create a PDF template based on Contact and include the decimal and float fields

9. Generate a PDF file of a contact that has a value in the decimal field and
   check that the decimal symbol is applied in the generated PDF template

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[SuiteBot]

All committers have signed the CLA.

[serhiisamko091184]

Hello @SinergiaCRM!

Thanks for so many contributions in the recent days!

Could you, please, remove comments in templateParser.php file:

Thanks in advance!

Regards,
Serhii

[SinergiaCRM]

Hello @serhiisamko091184, comments deleted 👍

Regards!!

[serhiisamko091184]

@SinergiaCRM, many thanks for the quick reply and the changes made!

Regards,
Serhii

[SinergiaCRM]

Hi, we have detected that it also occurs with float type fields so we have added the appropriate changes in the PR

[johnM2401]

LGTM,
Now using System-set values on Emails and User-set values on PDFs.

I have noticed that this issue is also present for currency-type fields,
see this email:

For the above, I have set:
System Thousand: "X" + System Decimal: "Z"
User Thousand: "." + User Decimal: ","

And the custom Currency->Amount Field is using the user's settings.

However, as this PR resolves the issue for both Decimal and Float, I'm happy to approve as-is.

Thank you again!