Fix #8838 - Change logo even if tmp folder contains periods

[SinergiaCRM]

Description

This PR checks if the variable $ext contains a "/". If so, it means it is not an extension, so it should get the value of $path

Motivation and Context

A logo image can't be uploaded through Admin / System settings area if the tmp folder's name contains at least one period.

How To Test This

1. Host a SuiteCRM instance where the tmp folder full path contains at least one period. For example /test.test/tmp
2. Try to upload an image using through the Admin / System settings area and checks it is working.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[serhiisamko091184]

Thanks for the PR, @SinergiaCRM!

Regards,
Serhii

[serhiisamko091184]

Hello @SinergiaCRM,

I'd like to ask about the suggested control structure. The strpos function might return different values - bool and non-bool. Some of them might be evaluated as FALSE, for instance, 0 or "". In case of returning 0 as an index of the position, it could be treated as FALSE. The logic of the fix might be scrambled. What do you think?

Thanks in advance!

Regards,
Serhii

[SinergiaCRM]

I'd like to ask about the suggested control structure. The strpos function might return different values - bool and non-bool. Some of them might be evaluated as FALSE, for instance, 0 or "". In case of returning 0 as an index of the position, it could be treated as FALSE. The logic of the fix might be scrambled. What do you think?

Hi @serhiisamko091184, you are right!

I see in php.net that strpos() returns false if the needle was not found so I think we can solve it in the following way.

    if (strpos($ext, '/') !== false) {
        $ext = $path;
    }

I just uploaded the change to PR.
Does this seem right to you?