Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10486 - Fix filtering in Email queue list view #10487

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

Description

This PR adds the name of the organizations in the filter by Recipient Name and modifies the query that is executed when querying by Recipient Email.

How To Test This

  1. Create a campaign with contacts, accounts, leads and users.
  2. Send one or more marketing emails.
  3. Access the message queue view and check:
  • The message related to the account recipient is returned when filtering by Recipient Name
  • The corresponding messages are returned when using the Recipient Email filter

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Area: Emails:Campaigns Issues & PRs related to email campaigns Branch:Hotfix PR 4-8 Score given to PRs once assessed labels Aug 6, 2024
@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,

thanks for your PR!

Regards,
Serhii

@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,

thanks for your contribution,

I'd like to ask is there a reason to apply changes, particularly to a metadata file in this case (subquery on 'to_email' search field)?

I'm asking as in the EmailMan class there's a function 'create_new_list_query', which could be modified to get the result.

Thanks in advance!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added Status:In Review Pull Requests that are activity being reviewed by the core team and removed Status: Requires Code Review Needs the core team to code review labels Aug 26, 2024
@SinergiaCRM
Copy link
Contributor Author

SinergiaCRM commented Aug 26, 2024

Hello @SinergiaCRM,

thanks for your contribution,

I'd like to ask is there a reason to apply changes, particularly to a metadata file in this case (subquery on 'to_email' search field)?

I'm asking as in the EmailMan class there's a function 'create_new_list_query', which could be modified to get the result.

Thanks in advance!

Regards, Serhii

Hi @serhiisamko091184,

No, there is no particular reason. We applied it in the metadata file because it solved the problem.

For now, we understand that you have located the solution in the create_new_list_query() method, so do you apply it? Do we have to do something in the PR?

Regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Emails:Campaigns Issues & PRs related to email campaigns Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status:In Review Pull Requests that are activity being reviewed by the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants