Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy saleor-app-payment-stripe to fly.io with Dockerfile #220

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

allen-munsch
Copy link
Contributor

@allen-munsch allen-munsch commented Oct 4, 2024

I was facing some deployment issues with what was in the canary autogenerated fly.io Dockerfile

  1. Related to: Running prepare after prune --prod breaks CI pnpm/pnpm#4770 (comment)
  2. When deploying, to fly.io, it didn't appear the ENVs were being set, probably a security issue since env vars are being set?
  3. i had to do some weirdness with the --legacy-peers-dep to get the graphql codegen to run
  4. the installation of json schema compiler as well

Wondering if maybe I was just doing it wrong, but maybe someone else will find this useful:

git clone [email protected]:saleor/saleor-app-payment-stripe.git
fly login
fly launch
fly set secrets APP_DEBUG=debug SECRET_KEY=$SECRET_KEY APL=file
fly deploy

Or:

docker build -t stripe-app  . 
# and then
docker run -e 'SECRET_KEY=okay-test-okay' -it stripe-app

@allen-munsch allen-munsch requested a review from a team as a code owner October 4, 2024 22:42
Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 6fd8368

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 4, 2024

@allen-munsch is attempting to deploy a commit to the Saleor Commerce Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2024

CLA assistant check
All committers have signed the CLA.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@lkostrowski lkostrowski requested a review from a team October 8, 2024 06:35
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@allen-munsch
Copy link
Contributor Author

@NyanKiyoshi @lkostrowski 🙏 Thank you very much for the code reviews, I've pushed a cleaner version.

It seemed to work much more quickly and without any hangups on versioning or the schema compiler.

git clone ...
fly login
fly launch
fly set secrets APP_DEBUG=debug SECRET_KEY=$SECRET_KEY APL=file
fly deploy

Copy link
Member

@NyanKiyoshi NyanKiyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this, the Dockerfile looks good to me! Thank you! 🙌

Dockerfile Outdated Show resolved Hide resolved
@allen-munsch allen-munsch changed the title Dockerfile update deploy saleor-app-payment-stripe to fly.io with Dockerfile Oct 9, 2024
package.json Outdated Show resolved Hide resolved
Copy link
Member

@krzysztofzuraw krzysztofzuraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested changes locally - it works without a problem 🎉
Thanks for your contribution 🙇🏻‍♂️

@lkostrowski lkostrowski merged commit 3da49fa into saleor:canary Oct 15, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants