-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy saleor-app-payment-stripe to fly.io with Dockerfile #220
Conversation
|
@allen-munsch is attempting to deploy a commit to the Saleor Commerce Team on Vercel. A member of the Team first needs to authorize it. |
@NyanKiyoshi @lkostrowski 🙏 Thank you very much for the code reviews, I've pushed a cleaner version. It seemed to work much more quickly and without any hangups on versioning or the schema compiler.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from this, the Dockerfile
looks good to me! Thank you! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested changes locally - it works without a problem 🎉
Thanks for your contribution 🙇🏻♂️
I was facing some deployment issues with what was in the
canary
autogenerated fly.io Dockerfileprepare
afterprune --prod
breaks CI pnpm/pnpm#4770 (comment)--legacy-peers-dep
to get the graphql codegen to runWondering if maybe I was just doing it wrong, but maybe someone else will find this useful:
Or: