Add ALLOWED_DOMAIN_PATTERN env #200
Conversation
🦋 Changeset detectedLatest commit: e9c9ef8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lkostrowski
force-pushed
the
protect-cloud-instsallations
branch
from
b3165d9
to
42c1702
Compare
| */ | ||
| (url) => { | ||
| if (allowedUrlsPattern) { | ||
| const regex = new RegExp(allowedUrlsPattern); |
There was a problem hiding this comment.
Question: Security concern
Will this setting be available to our end users? If yes I'm wondering if there will be the case they provide regex that will cause app to break 🤔
There was a problem hiding this comment.
In L6 you can see that this is coming from ENV that is set on the server side.
So, OSS will leave it empty or lock into their own envs. Saleor Cloud sets this to be only Cloud
Coverage report
Test suite run success261 tests passing in 104 suites. Report generated by 🧪jest coverage report action from e9c9ef8 |
No description provided.