Entry widget and secure conversations v2 #1036
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
changed the title
rasmustautsglia
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
2 times, most recently
from
cd21e48
to
fa640ff
Compare
ykyivskyi-gl
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
cfb864f
to
17349d7
Compare
rasmustautsglia
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
cdf1e06
to
cac42b4
Compare
igorkravchenko
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
aed3878
to
0228f93
Compare
igorkravchenko
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
7a5e1a8
to
f4300ab
Compare
|
@rasmustautsglia I think the target branch should be changed to 'development', shouldn't it? |
igorkravchenko
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
f4300ab
to
ef727e2
Compare
This commit extend clone-snapshots-ci make command by running checkout.sh script, which tries to make checkout to the source branch in Snapshots if it exists, otherwise tries to make checkout to the destination branch if it exists, otherwise makes checkout to master branch MOB-3716
EgorovEI
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
ed763eb
to
68ade5b
Compare
EgorovEI
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
68ade5b
to
e0349d0
Compare
EgorovEI
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
e0349d0
to
6606af7
Compare
This commit fixes the case when OutgoingMessage stored in messagesSection did not include attachment object. It led to the situation when the attachment was missed if initial send message request failed. MOB-3724
igorkravchenko
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
9b2e7c1
to
14d76ce
Compare
After adding AlertManager class configuring alert dialogs was broken. As a result for Audio, 1-way Video, 2-way Video offers the SDK always showed 2-way Video media upgrade dialog. That was only UI configuration issue, accepting the offer resulted in establishing right media type. This commit fixes alert configuration issue. MOB-3768
This PR adds EntryWidget bottom sheet. In addition it adds the necessary support files to be able to develop EntryWidget with SwiftUI. MOB-3477
This PR adds the possibility to embed EntryWidget to a view. Also, as was agreed upon within the team, there is no instance of EntryWidget within Glia. EntryWidget instance will be returned from getEntryWidget method MOB-3479
Add Unified Customization to EntryWidget, as well as add missing UI elements to accompany the customization options MOB-3592
According to the design, new media type texts were added MOB-3616
This commit introduces: - new alert dialog called Leave Current Conversation; - style for the same dialog MOB-3734
This commit: - Extends RemoteConfiguration.AlertStyle with negativeNeutralButton - fixes missed applying buttons alignment in alerts MOB-3737
This PR checks for authentication status to determine if secure messaging will be displayed in the available media type section in Entry Widget MOB-3658
Group accessibility media items. Add accessibility hints and types of items. MOB-3697
Introduce new UI to indicate that sending of messages is unavailable on chat screen. MOB-3726
Add unified customization send message unavailability indicator for chat screen. MOB-3742
UISheetPresentation is by default favouring full screen cover in landscape mode, due to lack of space. This however also disables drag to dismiss. This behavior is overwritten in this PR and allows the sheet to be dismissed with click and with drag. MOB-3731
According to new SC 2.0 design we use 'send message unavailability' view instead of dialog. These changes remove dialog and show banner instead. MOB-3739
Add toggling of SC bottom banner visibility based view model. MOB-3719
Fix and add missed attributes. Add a custom redacted placeholder that is not transparent by default. MOB-3745
Due to the different nature of chat and call views, the behaviour of alert dismissal worked way different. For Audio and Video engagements, when confrmation dialog was declined, the engagement view was dismissed alongside Entrywidget sheet. This was not intended. But for Chat, the dialog dismissal didn't dismiss EntryWidget sheet. To align them all, the entry widget is not dismissed when media type has been selected. It also looks much better visually now with the animation. MOB-3760
This PR covers EntryWidget with snapshot tests. This also includes adding mocks for EntryWidget and EntryWidget Environment. In addition, poweredBy was altered to allow scaling with font. MOB-3545
static let was changed to static method and it didn't raise alarms during rebasing
- Remove computed properties for title, subtitle, and hint from the MediaTypeItem. - Add properties for the title, subtitle, and hint for each media type to the Entry Widget Style structures. - Add functions that return the title, subtitle, and hint for the MediaTypeItem. - Use functions from the Entry Widget Style structures in the EntryWidgetView to display strings. MOB-3753
Introduce disabled state for ChatMessageEntry style for SC 2.0. MOB-3748
Since message entry can have disabled state, file upload list, which is a part of message entry, also needs to have disabled state. These changes introduce such state. Styles use same colors for disabled state as for enabled for now, because we do not have a flow for disabled file upload. MOB-3763
EgorovEI
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
ea35791
to
1ea3ecf
Compare
EgorovEI
force-pushed
the
development
branch
from
0212a21
to
60eac36
Compare
According to new design for SC 2.0 buttons are not longer hidden but disabled. MOB-3781
This commit introduces handling Live chat to Secure Conversations transferring MOB-3630
This PR adds logs to EntryWidget, and aligning iOS with Android logs. Because logger was added as a dependency to QueueMonitor, it was necessary to move queueMonitor from Glia environment to Glia's class property due to Logger being initialized during GliaSDK initialization. Because of that some changes can be seen in tests as well. MOB-3481
Update default global colors according to Mobile Color Tokens palette MOB-3710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was solved?
Release notes:
Additional info:
Screenshots: