better way to "transparent navigation bar"

sal0max · Dec 16, 2021 · 0496b7a · 0496b7a
1 parent 81c2567
commit 0496b7a
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 21 deletions.
diff --git a/app/src/main/kotlin/de/salomax/currencies/view/BaseActivity.kt b/app/src/main/kotlin/de/salomax/currencies/view/BaseActivity.kt
@@ -1,13 +1,8 @@
 package de.salomax.currencies.view
 
-import android.content.Context
-import android.graphics.Color
-import android.os.Build
 import android.os.Bundle
 import androidx.appcompat.app.AppCompatActivity
 import androidx.appcompat.app.AppCompatDelegate
-import androidx.core.view.WindowInsetsControllerCompat
-import com.google.android.material.color.MaterialColors
 import de.salomax.currencies.R
 import de.salomax.currencies.repository.Database
 
@@ -31,21 +26,7 @@ abstract class BaseActivity : AppCompatActivity() {
             }
         )
 
-        // "transparent" navigation bar
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O_MR1) {
-            window.navigationBarColor = MaterialColors.getColor(this, R.attr.colorBackground, Color.BLACK)
-            WindowInsetsControllerCompat(window, window.decorView).isAppearanceLightNavigationBars = booleanFromAttribute(R.attr.isLightTheme)
-            WindowInsetsControllerCompat(window, window.decorView).isAppearanceLightStatusBars = booleanFromAttribute(R.attr.isLightTheme)
-        }
-
         super.onCreate(savedInstanceState)
     }
 
-    private fun Context.booleanFromAttribute(attribute: Int): Boolean {
-        val attributes = obtainStyledAttributes(intArrayOf(attribute))
-        val dimension = attributes.getBoolean(0, false)
-        attributes.recycle()
-        return dimension
-    }
-
 }
diff --git a/app/src/main/res/values-v27/styles.xml b/app/src/main/res/values-v27/styles.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+
+    <style name="AppTheme" parent="BaseAppTheme">
+        <!-- "transparent" navigation bar -->
+        <item name="android:navigationBarColor">?attr/colorBackground</item>
+        <item name="android:windowLightNavigationBar">?attr/isLightTheme</item>
+    </style>
+
+    <style name="AppTheme.Black" parent="BaseAppTheme.PureBlack">
+        <!-- "transparent" navigation bar -->
+        <item name="android:navigationBarColor">?attr/colorBackground</item>
+        <item name="android:windowLightNavigationBar">?attr/isLightTheme</item>
+    </style>
+
+</resources>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
@@ -3,7 +3,11 @@
     <attr name="colorDisplayOverlay" format="reference|color" />
     <attr name="colorBackground" format="reference|color" />
 
-    <style name="AppTheme" parent="Theme.MaterialComponents.DayNight">
+    <!-- themes to be applied -->
+    <style name="AppTheme" parent="BaseAppTheme" />
+    <style name="AppTheme.PureBlack" parent="BaseAppTheme.PureBlack" />
+
+    <style name="BaseAppTheme" parent="Theme.MaterialComponents.DayNight">
         <!-- colors -->
         <item name="colorBackground">@color/colorBackground</item>
         <item name="colorAccent">@color/colorAccent</item>
@@ -35,7 +39,7 @@
         <item name="colorOnError">?android:attr/textColorPrimary</item>
     </style>
 
-    <style name="AppTheme.PureBlack" parent="AppTheme">
+    <style name="BaseAppTheme.PureBlack" parent="AppTheme">
         <!-- colors -->
         <item name="colorBackground">@color/colorBackgroundPureBlack</item>
         <item name="colorDisplayOverlay">@color/displayOverlayPureBlack</item>