fix: Auto switch elytra #6
Conversation
|
Okay, I'll test this out. I love how you are using my Enchantment level code as part of this now. Using the setting part wasn't working out the way I was thinking. |
|
The ideas I was testing before, had everything to do with Falling versus trying to fly, and how far, etc; or if the Chest slot was empty previously. |
|
Okay, so far, this version is working better than before, thank you. The way it was originally, was too janky; and it would keep activating even if you were just jumping up a block... |
|
I'll wait to merge until you reply and do any additional testing. |
…abric/1.21' into auto-switch-elytra # Conflicts: # src/main/java/fi/dy/masa/tweakeroo/mixin/MixinClientPlayerEntity.java
Yes it is a bug because minecraft tries to start flying even if the player isOnGround(), so I added a check for this. It is OK to merge now. |
|
I was only doing some simple reformatting, and taking notes of the "fallDistance" method for the future. |
|
Yes so it is ok to merge. Do you prefer to merging this PR now, or adding fallDistance threshold options in this PR? |
I don't think I'm going to add that if you've addressed the original issue. |
sakura-ryoko
merged commit 60d518f
into
sakura-ryoko:pre-rewrite/fabric/1.21
You said in your release note:
but this feature is broken with your changes, double jump didn't work. I have fixed it and removed the 20 block fall distance check.