-
Notifications
You must be signed in to change notification settings - Fork 5
Using ReLu as an Option instead of Sigmoid #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nereuxofficial
wants to merge
45
commits into
sakex:main
Choose a base branch
from
Nereuxofficial:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock
@Nereuxofficial Thanks it looks good. I will run some tests to see if it impacts my results. I keep you posted! |
@Nereuxofficial A good way to make it optional would be to have a trait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a proof of concept since in order for it to get merged it would have to be optional, i think it's a nice idea since it would be much faster. You can also try it out using my flappy bird for or just replace the version with { git = "https://github.com/Nereuxofficial/neat-gru-rust"} in another project
Using Cargo criterion and looking at the generated HTML pages you can also see the performance difference between sigmoid and ReLu with nice charts.