Skip to content

Commit

Permalink
Revert "Revert "[terra-icon] Favorite static icon update (cerner#3624)""
Browse files Browse the repository at this point in the history
This reverts commit ff60831.
  • Loading branch information
Saad Adnan authored and Saad Adnan committed Jun 9, 2022
1 parent ff60831 commit 5efc498
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 11 deletions.
5 changes: 5 additions & 0 deletions packages/terra-icon/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## Unreleased

* Changed
* Updated to `one-cerner-style-icons` v1.47.0
* Removed colored static favorite star in favor of using the themeable variant of the star icon
* Consumers that are currently using the static icon should change their reference to the themeable variant, as the duplicate static replacement will be removed at some point.

## 3.47.1 - (May 3, 2022)

* Changed
Expand Down
2 changes: 1 addition & 1 deletion packages/terra-icon/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"devDependencies": {
"csvtojson": "^2.0.8",
"jsdom": "^15.1.1",
"one-cerner-style-icons": "https://github.com/cerner/one-cerner-style-icons/archive/v1.46.1.tar.gz",
"one-cerner-style-icons": "https://github.com/cerner/one-cerner-style-icons/archive/v1.47.0.tar.gz",
"shelljs": "^0.8.2",
"svgo": "^1.2.2"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,7 @@
/* stylelint-disable selector-class-pattern */
:local {
.IconFeaturedOutlineYellow {
path:nth-of-type(1) {
fill: var(--terra-icon-featured-outline-yellow-path-1-fill, #ffc20a);
}

path:nth-of-type(2) {
fill: var(--terra-icon-featured-outline-yellow-path-2-fill, #231f20);
}
fill: var(--terra-icon-featured-outline-yellow-path-1-fill, #1c1f21);
}
}
/* stylelint-enable selector-class-pattern */
4 changes: 2 additions & 2 deletions packages/terra-icon/src/icon/IconFeaturedOutlineYellow.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ const SvgIcon = (customProps) => {

return (
<IconBase {...attributes} className={iconClassNames} >
<path d="M.7 20.1c-.4-.4-.7-.9-.7-1.5 0-.7.5-1.2 1.6-1.4L16.1 15l6.5-13.8C22.9.4 23.4 0 24 0s1.1.4 1.4 1.2L31.9 15l14.5 2.2c1.1.2 1.6.6 1.6 1.4-.1.6-.3 1.1-.8 1.5L36.8 30.8l2.5 15.1v.6c0 .4-.1.8-.3 1.1-.2.3-.5.5-.9.4-.4 0-.8-.1-1.2-.4l-13-7.1L11 47.6c-.3.2-.7.3-1.2.4-.4 0-.7-.1-.9-.4-.2-.3-.3-.7-.3-1.1 0-.2 0-.4.1-.6l2.5-15.1L.7 20.1z" fill="#ffc20a" ></path><path d="M24 5.3l5.2 11 .7 1.4 1.6.2 11.9 1.8-8.7 8.9-1.1 1.1.2 1.5 2 12.4-10.4-5.7-1.4-.8-1.4.8-10.4 5.7 2-12.4.2-1.5-1.1-1.1-8.7-8.9L16.5 18l1.6-.2.7-1.4L24 5.3M24 0c-.6 0-1 .4-1.4 1.2L16.1 15 1.6 17.2c-1.1.2-1.6.7-1.6 1.4.1.6.3 1.1.7 1.5l10.5 10.7-2.5 15.1c0 .2-.1.4-.1.6 0 .4.1.8.3 1.1.3.3.6.4 1 .4s.8-.1 1.2-.4l13-7.1 13 7.1c.3.2.7.3 1.2.4.3 0 .7-.1.9-.4.2-.3.3-.7.3-1.1v-.6L37 30.8l10.5-10.7c.4-.4.7-.9.8-1.5 0-.7-.5-1.2-1.6-1.4L31.9 15 25.4 1.2C25 .4 24.6 0 24 0z" fill="#231f20" ></path>
<path d="M.7 20.1a2.47 2.47 0 01-.7-1.5c0-.7.5-1.2 1.6-1.4L16.1 15l6.5-13.8C22.9.4 23.4 0 24 0s1 .4 1.4 1.2L31.9 15l14.5 2.2c1.1.2 1.6.6 1.6 1.4a2.75 2.75 0 01-.8 1.5L36.8 30.8l2.5 15.1v.6a2 2 0 01-.3 1.1 1 1 0 01-.9.4 1.92 1.92 0 01-1.2-.4l-13-7.1-13 7.1a2.84 2.84 0 01-1.2.4 1 1 0 01-.9-.4 2 2 0 01-.3-1.1 1.76 1.76 0 01.1-.6l2.5-15.1z" ></path>
</IconBase>
);
};

SvgIcon.displayName = "IconFeaturedOutlineYellow";
SvgIcon.defaultProps = {"viewBox":"0 0 48 48","xmlns":"http://www.w3.org/2000/svg"};
SvgIcon.defaultProps = {"viewBox":"0 0 48 48","xmlns":"http://www.w3.org/2000/svg","data-name":"Layer 1"};

export default SvgIcon;
/* eslint-enable */
2 changes: 1 addition & 1 deletion packages/terra-icon/src/svg/featuredOutlineYellow.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 5efc498

Please sign in to comment.