-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-50415 Syllabus ui responsiveness #12815
Conversation
@@ -196,7 +196,7 @@ | |||
<sakai:doc_section> | |||
<h:outputText value="#{msgs.newSyllabusBulkForm}"/> | |||
</sakai:doc_section> | |||
<h:panelGrid columns="1" styleClass="jsfFormTable"> | |||
<h:panelGrid columns="1" styleClass="jsfFormTable" style="table-layout:fixed; width:100%"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h:panelGrid columns="1" styleClass="jsfFormTable" style="table-layout:fixed; width:100%"> | |
<h:panelGrid columns="1" styleClass="jsfFormTable w-100" style="table-layout:fixed;"> |
Let's use bootstrap class where we can
@@ -208,15 +208,15 @@ | |||
</h:panelGroup> | |||
</h:panelGroup> | |||
<h:panelGroup> | |||
<h:selectOneRadio id="radioSingleItem" value="#{SyllabusTool.bulkEntry.addSingleItem}" styleClass="radioSingleItem radioOption radioOptionSelected"> | |||
<h:selectOneRadio id="radioSingleItem" value="#{SyllabusTool.bulkEntry.addSingleItem}" styleClass="radioSingleItem radioOption radioOptionSelected" style="width:100%"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this and others as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I updated the code and pushed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sharadhi98
@Sharadhi98 I'm just rebasing your branch onto master. You have a conflict. I will force push very soon, so don't do anything until I have. |
a1831e0
to
2e6d1ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kunal says this is good to go, it's good to go. Thanks Sharadhi.
@Sharadhi98 Do you know how to fix conflicts in your branches? When your code won't merge cleanly with master? I have no intention to patronise you, not everybody is good with git :) |
I'm not sure how to fix that, Adrian. I might have to Google/ChatGPT it and find out! |
It's not too hard and it's a good skill to know. |
Co-authored-by: Sharadhi <[email protected]> (cherry picked from commit 2ab0f50)
No description provided.