-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-50358 Assignment and Chat improve ui responsiveness #12796
base: master
Are you sure you want to change the base?
Conversation
@@ -128,6 +128,10 @@ | |||
width: 26vw; | |||
height: auto; | |||
} | |||
|
|||
.portal-main-container { | |||
display: block !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to avoid using !important and rely on css specificity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still trying to find out other ways but unable to do so yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you can describe the intent or the problem, we can suggest a solution. is some other code setting portal-main-container to inline or inline-block? if yes, do we know why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also looks like this change was already committed as part of #12787? I wonder why it's not being flagged as a conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ottenhoff I found an alternative bootstrap class "d-grid" to fix this issue. Please let me know if that works - the issue has been fixed.
@jonespm I will fix that - it is supposed to be only a part of this commit.
Fixed a small border-top change on the Chatroom tool.