Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization error in 'Tech Rampup' quest. #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathisto
Copy link
Contributor

Hail sir! I absolutely LOVE what you are doing here. If you are cool with it I am gonna start making PR's for clerical issues I find. Rather than leave you a trail of issues to fix on discord, I can just fix the thing and you can keep up the incredible work on this epic project of yours.

@sainagh
Copy link
Owner

sainagh commented Aug 25, 2024

Heya! I appreciate the help!

Because of the format of the betterquesting JSON, pull requests and merges don't work with git and multiple editors. We used to have a repo for people to add lore for smaller things, but it turned out a disaster because of this weird incompatibility.

I know I have been slow at addressing typos, but it also has to do with the issue of others not being able to merge things if I do edit things on my end.

With this I'll probably be able to copy-paste without many issues, but for larger things it may not be possible.

I still really appreciate the willingness to help, just gotta figure out a better way to do things as opposed to pull requests.

Let me know if you have suggestions on other ways this can be done!

@mathisto
Copy link
Contributor Author

Ooof, so sorry. I was deep in this follow up PR before I saw this. Feel free to use or discard whatever you like. I just want to help in anyway I can. I can only try to imagine the mountain of tasks you have in your backlog.

@sainagh
Copy link
Owner

sainagh commented Aug 25, 2024

Actually, if you started editing things from 0.16-hotfix2, or any of the later ones, it should be ok! I haven't done any major questbook editing after that point.

@mathisto
Copy link
Contributor Author

I think that is the case! Whooo hoo! I forked from your main last night, so if that is the case, all the edits should be kosher. The other PR has a bunch of these. If you like the flavor of my cleanup, let me know and I can take another pass through tooltips, baubles, info boxes as well.

@jchung01
Copy link

jchung01 commented Aug 28, 2024

The pack transitioned from FTB Quests (FTBQ) to BetterQuesting Unofficial (BQU) a while ago, so unless there is some logistical use of the old FTB quests by Sainagh I'm missing, any edits to FTBQ files won't affect the questbook in game. Normally, you would need to edit DefaultQuests.json in configs/betterquesting to actually change quest-related text (although it's easiest to change in-game).

However, BQU 4.2.3 (which is included in MBC 0.16) has brought a new change to split up all quests into multiple files. This way, instead of one monolithic json file with all the quest text, it will split the quests and questlines into their individual folders and jsons. Not sure if this is the best place to communicate this change or the Discord, but see the PR for more details. Notably, after running /bq_admin default save in-game, the old format will be converted to the new format, which is meant to be a lot easier for editing in version control. As mentioned in the PR, the BQ config option B:"DefaultQuests saves using Names"=true can also be enabled for better readability, but note the tradeoff mentioned in the config's comment about it.

So there is some setup for Sainagh to do, but in the long run, this new format should allow for better collaboration and resolves the issues he's mentioned here. In that case, it's probably best to hold back on submitting any changes to quests until Sainagh is able to migrate to the new quest format. Or at least keep the changes in mind for the future.

@sainagh
Copy link
Owner

sainagh commented Oct 20, 2024

I have not forgotten about this. If you still want to help, the questbook file system has been updated to a version-control-friendly format, so pull requests for typos and general questbook stuff are going to be a thing after new update comes out in a few days :)

sainagh pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants