Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0 #77

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

2.0.0 #77

wants to merge 25 commits into from

Conversation

silverman63
Copy link
Contributor

@silverman63 silverman63 commented Aug 10, 2017 •
edited
Loading

  • Client throws Sailthru_Client_Exception on API errors
  • Email API Removed
  • New User API function getUser added
  • Documentation updated
  • User API helper functions now will return all fields if none passed
  • Resolves getUserByKey default response is not working properly #66, returning all fields for getUserByKey if the fields arg is empty

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 15.976% when pulling 6de86d0 on 2.0 into 37f8ff4 on master.

rossmotley and others added 8 commits August 10, 2017 17:08
@rossmotley
New exception with curl error
318c63e 
Throwing an exception with the actual curl error, instead of the generic 'empty response' code.
@rossmotley
PHP 5.4 fix
aef6d58
@rossmotley
Removed url from curl error exception
82373c7 
The $url has the api_key in it, so it's probably best not to include it in the exception.
@rossmotley
Code review changes
48816cd 
* String interpolation
* Renamed curl exception message
* Renamed curl error constant
@silverman63
Merge branch '2.0.0' into httpErrorHandling
3877ee8
@silverman63
Refactoring httpRequest exceptions, adding without curl test
d999637
@silverman63
making errors match in formatting
993da87
@silverman63
Merge pull request #79 from sailthru/httpErrorHandling
43fb5a6 
More verbose httpRequest Error Handling
@coveralls
Copy link

Coverage Status

Coverage increased (+3.6%) to 18.468% when pulling 43fb5a6 on 2.0 into 37f8ff4 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 18.288% when pulling 4a62149 on 2.0 into 37f8ff4 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silverman63 @coveralls @rossmotley