Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: clean up getConnection() test properly #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: clean up getConnection() test properly #29

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43808f0
Fix: clean up getConnection() test properly
Dec 10, 2019
7042f45
shouldn't need to release the connection if destroying the pool in `a…
mikermcneil Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/integration/connectable/get-connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ describe('Connectable ::', function() {
});
});

after(function(done) {
manager.pool.end(done);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the mp-postgresql destroyManager method for this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you 🙂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this more, I think the above approach is preferable to using the library under test for cleanup.

});

it('should successfully return a PG Client instance', function(done) {
Pack.getConnection({
manager: manager
Expand All @@ -39,8 +43,9 @@ describe('Connectable ::', function() {
// Assert that a PG Client is returned
assert(report.connection instanceof pg.Client);

// Assert that the connection has a release function
assert(report.connection.release);
// Assert that the connection has a release function, and call it to
// release the connection.
report.connection.release();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the assert here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it add value? If report.connection.release is not defined, then this line will throw anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, but I'd like to keep this PR to just the minimal set of changes needed for the fix

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So your preference would be something like below?

        // Assert that the connection has a release function
        assert(report.connection.release);

        // Call the release function on the connection to release the connection
        report.connection.release();


return done();
});
Expand Down