Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jb57663 #323

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Jb57663 #323

wants to merge 2 commits into from

Conversation

martyone
Copy link
Member

@martyone martyone commented Mar 4, 2022

No description provided.

@martyone martyone requested a review from vigejolla March 4, 2022 07:07
Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this more. I don't really like this approach because it will result in people leaving their passwords in a plain text file. While they can remove the file after they have finished their business, I doubt many will. I would consider prompting for the username and password on the sfdk side, writing the information to a file there, which would then be used in sdk-manage, and then removed after finishing with sdk-manager. The password would still be in plain text file during the operation, but it would be removed immediately so the risk would be smaller.

@Thaodan
Copy link
Contributor

Thaodan commented Mar 7, 2022

Thinking about this more. I don't really like this approach because it will result in people leaving their passwords in a plain text file. While they can remove the file after they have finished their business, I doubt many will. I would consider prompting for the username and password on the sfdk side, writing the information to a file there, which would then be used in sdk-manage, and then removed after finishing with sdk-manager. The password would still be in plain text file during the operation, but it would be removed immediately so the risk would be smaller.

Since we already use gpg we could also advice people to use an encrypted netrc.

@vigejolla
Copy link
Member

Since we already use gpg we could also advice people to use an encrypted netrc.

Does curl support that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants