-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename also set-like species #39338
base: develop
Are you sure you want to change the base?
rename also set-like species #39338
Conversation
We provide traditional names for atomic species that are products or substitutions of the species of sets The next two steps are:
|
Documentation preview for this PR (built with commit 02b57f4; changes) is ready! 🎉 |
One thing I dislike is that it will create a new list for every set of variables. I didn't check how expensive that is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check this test error out:
Check failure on line 455 in src/sage/rings/species.py
GitHub Actions / test-new
Failed example:
Failed example:: Got: E_2(X*Y)
```
as seen in the list of chnages
Sorry, I forgot to adapt the doctests in the multisort case. |
📝 Checklist
⌛ Dependencies