[WIP] Fix build and tests with pari 2.17 #38749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs work because this is not compatible with 2.15. So either it needs to be merged with the pari upgrade or be made to work with older pari too (no idea how). Running tests now. |
|
Many test failures. |
antonio-rojas
changed the title
NEXT_PRIME_VIADIFF is removed in 2.17, port pari_prime_range to pari_PRIMES instead
2 tasks
antonio-rojas
force-pushed
the
pari-2.17
branch
from
a6acbfb
to
f619b6f
Compare
|
If the changes here eventually allow us to use a system Pari 2.17, then we should undo the change in #38772. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEXT_PRIME_VIADIFFis removed in 2.17, portpari_prime_rangetopari_PRIMESinsteadNeeds sagemath/cypari2#165 applied to cypari