Enable creation of minimal Weierstrass models from cubics #38744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow EllipticCurve_from_cubic to return a minimal model.
|
Documentation preview for this PR (built with commit 7fda240; changes) is ready! 🎉 |
Make sure to do minimize check when E has a flex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality desired in #33343 to the constructor
EllipticCurve_from_cubic.Rather than always make the cubic a minimal model when possible, this modification adds a keyword argument minimize that, if set to True, returns a minimal Weierstrass model (and a morphism from the cubic to it if morphism is True).