Expose Coxeter and dual Coxeter numbers in RootSystem class #38730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you should not touch ruff.toml |
skipgaribaldi
force-pushed
the
coxeter-and-dual-coxeter-numbers
branch
from
a45f803
to
3dcc315
Compare
Of course! Sorry. This is my first pull request. Fixed |
tscrim
requested changes
Oct 2, 2024
Co-authored-by: Travis Scrimshaw <[email protected]>
Co-authored-by: Travis Scrimshaw <[email protected]>
Co-authored-by: Travis Scrimshaw <[email protected]>
Co-authored-by: Travis Scrimshaw <[email protected]>
|
Thank you. Once the bots come back green, I will set a positive review. In the future, if you could refrain from using GH's "implement suggestion" (or whatever it is exactly called) and make a proper commit, or at least give more precise commit messages, that would be appreciated. The generic "Update XYZ" makes it a bit harder if we have to dig into the history. Thank you for the improvements! Please feel free to cc me on any PRs that are related to root systems, Lie groups/algebras, representation theory. etc. Feel free to contact me directly by email (see my GH profile) to discuss things such as missing features or issues. |
tscrim
reviewed
Oct 2, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 5, 2024
…em class
Makes the Coxeter number and dual Coxeter number, which are properties
of a root system, available in the RootSystem class.
The underlying functions already exist in the CartanType, so this is a
matter of exposing them in the RootSytem class.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X ] The title is concise and informative.
- [X ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ X] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
URL: sagemath#38730
Reported by: Skip G
Reviewer(s): Skip G, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the Coxeter number and dual Coxeter number, which are properties of a root system, available in the RootSystem class.
The underlying functions already exist in the CartanType, so this is a matter of exposing them in the RootSytem class.
📝 Checklist
⌛ Dependencies