This repository was archived by the owner on Dec 17, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first set of changes to reorganize the sage images, including the makefile, their dockerfiles, and the sage installation script that runs in the containers. This doesn't do everything I want yet, but it partially addresses:
sagemath
andsagemath-develop
images from ~7 GB to ~4 GB. More could probably be done but that's a good start.sage
user. By default sage is installed to/opt/sage/
(thesage
user does not have permissions on/opt/
but they can read/write to/opt/sage/
. TheirDOT_SAGE
is still in thesage
user's home directory). However, it is also possible to change the installation location for sage. Regardless thesage
user has full permissions on the install location.Still to do (in a separate PR):
SAGE_BRANCH
argument. I intend to eliminate the separatesagemath-develop
Dockerfile, and instead add additional make targets for "develop" versions of all relevant images (currently just "sagemath" and "sagemath-jupyter"--sagemath-patchbot is of course a separate case). Building the "-develop" versions is mostly just a matter of running the build target with an additional option to change theSAGE_BRANCH
variable. This would finally eliminate any duplication.