Use Py_CLEAR() to avoid a data race (#221) #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix #221
It turns out that
is unsafe, if the code is interrupted in between the two statements [0].
This is what happens in #221. Then
verify_exc_value()
is called again withcysigs.exc_value.ob_refcnt=0
, breaking badly. Later on this causesverify_exc_value()
to be called withcysigs.interrupt_received=1
whichshould not happen.
Using instead the safe macro
Py_CLEAR()
seems to fix the issue.[0] See the warning in
https://docs.python.org/3/c-api/refcounting.html#c.Py_DECREF
and see also
https://docs.python.org/3/c-api/refcounting.html#c.Py_CLEAR