Skip to content

use logging to log all exceptions #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kliem
Copy link

@kliem kliem commented Nov 24, 2021

#155 is difficult to figure out. The reason is simple. The exceptions in rundoctests are caught and printed with

try:
    failures, _ = doctest.testfile(file, module_relative=False, optionflags=flags, parser=parser)
if not failures:
    os._exit(0)
except BaseExcept as E:
    print(E)
finally:
    os._exit(23)

However, the exceptions thrown by sig_on are not of type BaseExcept. We use logging.exception instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant