-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow tabNavigation to transactions page #4745
Conversation
Branch preview❌ Deploy failed! |
All contributors have signed the CLA ✍️ ✅ |
Coverage (56%)
|
@Jonathansoufer thanks! You might need to sign your commits though |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted the PR title as per https://www.notion.so/safe-global/How-to-name-pull-requests-fd1c28aa83544239a02f47d1936adc0d
Nice work!
Looks like lint and tests are failing though.
e2a7c41
to
1fc09cd
Compare
What it solves
Resolves #
A blocker bug which would throw an error leading to breaking the app when user navigates to Transaction tab.
How this PR fixes it
This was due a conflict version between expo-route package and @react-navigation/core, as well as a duplicate mention of @react-navigation in yarn.lock.
How to test it
Launch the app and navigate to Transaction tab.
Screenshots
Before
After
Checklist