Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow tabNavigation to transactions page #4745

Closed
wants to merge 3 commits into from

Conversation

Jonathansoufer
Copy link
Contributor

What it solves

Resolves #
A blocker bug which would throw an error leading to breaking the app when user navigates to Transaction tab.

How this PR fixes it

This was due a conflict version between expo-route package and @react-navigation/core, as well as a duplicate mention of @react-navigation in yarn.lock.

How to test it

Launch the app and navigate to Transaction tab.

Screenshots

Before

Screenshot 2025-01-07 at 16 32 40

After

Screenshot 2025-01-07 at 16 46 38

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@Jonathansoufer Jonathansoufer added the bug Something isn't working label Jan 7, 2025
@Jonathansoufer Jonathansoufer self-assigned this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Branch preview

❌ Deploy failed!

Copy link

github-actions bot commented Jan 7, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

github-actions bot commented Jan 7, 2025

Coverage (56%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files55.5649.8149.6556.04 
src0000 
   react-app-env.d.ts0000 
src/components/Alert10091.66100100 
   Alert.tsx10091.6610010055
   index.ts0000 
src/components/Badge87.587.510087.5 
   Badge.tsx85.7187.510085.7149
   index.ts0000 
   theme.ts100100100100 
src/components/BlurredIdenticonBackground0000 
   BlurredIdenticonBackground.tsx000014–51
   index.tsx0000 
src/components/ChainsDisplay10084.61100100 
   ChainsDisplay.tsx10084.6110010015–18
   index.ts0000 
src/components/Container10075100100 
   Container.tsx1007510010032
   index.ts0000 
src/components/CopyButton010000 
   CopyButton.tsx0100005–10
   index.ts0000 
src/components/DataRow100100100100 
   DataRow.tsx100100100100 
   index.ts0000 
src/components/Dropdown88.46607088 
   Dropdown.tsx81.256057.1481.2555, 63, 128
   index.ts0000 
   sheetComponents.tsx100100100100 
src/components/EthAddress0000 
   ETHAddress.tsx000011–12
   index.ts0000 
src/components/Fiat100100100100 
   Fiat.tsx100100100100 
   index.ts0000 
src/components/Identicon100100100100 
   Identicon.tsx100100100100 
   index.ts0000 
src/components/InnerShadow100100100100 
   InnerShadow.tsx100100100100 
   index.ts0000 
src/components/Logo100100100100 
   Logo.tsx100100100100 
   index.ts0000 
src/components/SafeButton100100100100 
   SafeButton.tsx100100100100 
   index.ts0000 
src/components/SafeFontIcon87.585.7110087.5 
   SafeFontIcon.tsx87.585.7110087.528
   index.ts0000 
src/components/SafeListItem10066.66100100 
   SafeListItem.tsx10066.6610010074–88
   index.tsx0000 
src/components/SafeTab250026.31 
   SafeTab.tsx44.44100044.4413–25
   SafeTabBar.tsx9.09001018–38
   index.tsx0000 
   types.ts0000 
src/components/StatusBanners/PendingTransactions10050100100 
   PendingTransactions.tsx1005010010017
   index.tsx0000 
src/components/Tab0000 
   TabNameContext.tsx00003–10
src/components/Title100100100100 
   LargeHeaderTitle.tsx100100100100 
   NavBarTitle.tsx100100100100 
   index.ts0000 
src/components/TxInfo23.84.545023.8 
   TxInfo.tsx23.84.545023.845–96, 100
   index.tsx0000 
src/components/navigation100100100100 
   TabBarIcon.tsx100100100100 
   index.ts0000 
src/components/transactions-list/Card/AccountCard10075100100 
   AccountCard.tsx1007510010052
   index.ts0000 
src/components/transactions-list/Card/AssetsCard100100100100 
   AssetsCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxBatchCard100100100100 
   TxBatchCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxConflictingCard010000 
   TxConflictingCard.tsx01000013–31
   index.tsx0000 
src/components/transactions-list/Card/TxContractInteractionCard100100100100 
   TxContractInteractionCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxCreationCard100100100100 
   TxCreationCard.tsx100100100100 
   index.ts0000 
src/components/transactions-list/Card/TxGroupedCard90.9757590.9 
   TxGroupedCard.tsx90.9757590.957
   index.tsx0000 
src/components/transactions-list/Card/TxRejectionCard100100100100 
   TxRejectionCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxSafeAppCard100100100100 
   TxSafeAppCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxSettingsCard10050100100 
   TxSettingsCard.tsx1005010010017
   index.tsx0000 
src/components/transactions-list/Card/TxSwapCard100100100100 
   TxSwapCard.tsx100100100100 
   index.tsx0000 
src/components/transactions-list/Card/TxTokenCard88.8880.5510088.88 
   TxTokenCard.tsx88.8880.5510088.8840, 70
   index.tsx0000 
src/config44.4483.33044.44 
   constants.ts10083.3310010015
   ethers.ts01000010–38
src/features/Assets010000 
   Assets.container.tsx0100009–21
   index.tsx0000 
   styles.ts010010003
src/features/Assets/components/AccountItem91.6668.7510090.9 
   AccountItem.tsx91.6668.7510090.924
   index.ts0000 
src/features/Assets/components/AccountItem/hooks5002553.84 
   useEditAccountItem.ts5002553.8415–29
src/features/Assets/components/AssetsHeader0000 
   AssetsHeader.container.tsx0100006–13
   AssetsHeader.tsx000015
   index.tsx0000 
   styles.ts010010003
src/features/Assets/components/Balance0000 
   Balance.container.tsx01000014–36
   Balance.tsx000025–42
   ChainItems.tsx000017–28
   index.tsx0000 
src/features/Assets/components/Fallback10075100100 
   Fallback.tsx1007510010012
   index.ts0000 
src/features/Assets/components/MyAccounts88.2310066.66100 
   MyAccounts.container.tsx100100100100 
   MyAccountsFooter.tsx71.4210033.33100 
   index.ts0000 
src/features/Assets/components/MyAccounts/hooks43.7533.335044.82 
   useMyAccountsService.ts100100100100 
   useMyAccountsSortable.ts000012–38
src/features/Assets/components/NFTs10081.81100100 
   NFTItem.tsx100501001008
   NFTs.container.tsx10088.8810010026
   index.tsx0000 
src/features/Assets/components/Navbar0000 
   Navbar.tsx000018–66
   index.tsx0000 
src/features/Assets/components/NoFunds100100100100 
   EmptyToken.tsx100100100100 
   NoFunds.tsx100100100100 
   index.ts0000 
src/features/Assets/components/Tokens100100100100 
   Tokens.container.tsx100100100100 
   index.tsx0000 
src/features/Notifications010000 
   Notifications.container.tsx0100004–5
   index.tsx0000 
src/features/Onboarding100100100100 
   Onboarding.container.tsx100100100100 
   index.ts0000 
src/features/Onboarding/components/OnboardingCarousel9510087.595 
   CarouselFeedback.tsx100100100100 
   CarouselItem.tsx100100100100 
   OnboardingCarousel.tsx83.331008083.3318
   index.ts0000 
   items.tsx100100100100 
src/features/Onboarding/components/OnboardingHeader100100100100 
   OnboardingHeader.tsx100100100100 
   index.ts0000 
src/features/Onboarding/components/ParticlesLogo100100100100 
   ParticlesLogo.tsx100100100100 
   index.ts0000 
src/features/PendingTx0000 
   PendingTx.container.tsx0100006–8
   index.tsx0000 
   utils.tsx000021–133
src/features/PendingTx/components/PendingTxList0000 
   PendingTxList.container.tsx000033–63
   index.ts0000 
src/features/Settings0000 
   Settings.container.tsx00007–14
   Settings.tsx000020–137
   index.tsx0000 
src/features/Settings/components/AppSettings010000 
   AppSettings.container.tsx0100007–20
   AppSettings.tsx01000010–11
   index.ts0000 
src/features/Settings/components/IdenticonWithBadge10050100100 
   IdenticonWithBadge.tsx1005010010021–22
   index.ts0000 
src/features/Settings/components/Navbar0000 
   Navbar.tsx01000010–27
   SettingsButton.tsx0100006–15
   SettingsMenu.tsx000017–81
   index.ts0000 
src/features/Signers010000 
   Signers.container.tsx0100003–4
   index.tsx0000 
src/features/TxHistory0000 
   TxHistory.container.tsx000011–37
   index.tsx0000 
   utils.tsx000018–58
src/features/TxHistory/components/TxHistoryList0000 
   TxHistoryList.tsx000018–32
   index.ts0000 
src/hooks/useCopyAndDispatchToast100100100100 
   index.ts100100100100 
src/hooks/useInfiniteScroll75508073.33 
   index.ts0000 
   useInfiniteScroll.ts75508073.3330–35
src/hooks/usePendingTxs0000 
   index.ts000015–40
src/hooks/useSign805010080 
   index.ts0000 
   useSign.ts80501008034, 43, 55, 62, 67
src/hooks/useTransactionType91.6679.1610091.66 
   index.tsx91.6679.1610091.66116–124
src/navigation0000 
   useScrollableHeader.tsx000022–47
src/services/exceptions88.8810010088.88 
   utils.ts88.8810010088.8814
src/store66.665040.966.66 
   activeSafeSlice.ts751005071.4219–22
   constants.ts100100100100 
   index.ts91.665010091.6644
   myAccountsSlice.ts83.33100508013
   safesSlice.ts37.510012.538.4638–48, 57–58
   storage.ts251000258–17
   txHistorySlice.ts100100100100 
src/store/chains68.421004075 
   index.ts68.42100407517, 30–33
src/store/hooks100100100100 
   index.ts100100100100 
src/theme100100100100 
   navigation.ts100100100100 
   tamagui.config.ts100100100100 
   tokens.ts100100100100 
src/theme/helpers10081.81100100 
   utils.ts10081.8110010037, 41
src/theme/palettes100100100100 
   darkPalette.ts100100100100 
   lightPalette.ts100100100100 
src/theme/provider59.0927.776059.09 
   font.tsx90501009034
   safeTheme.tsx10037.510010019–34
   toastProvider.tsx000010–29
src/utils75.6547.9172.0975.7 
   date.ts9666.6685.7110031, 35–39
   formatters.ts908010088.889
   gateway.ts100100100100 
   transaction-guards.ts79.24606880.7650–56, 66, 98, 102, 116, 120
   transactions.tsx00004–29

@clovisdasilvaneto
Copy link
Contributor

@Jonathansoufer thanks! You might need to sign your commits though

@Jonathansoufer
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@clovisdasilvaneto clovisdasilvaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks a lot!

@katspaugh katspaugh changed the title Fix: Fixing the tabNavigation issue Fix(Mobile): fix a tabNavigation issue Jan 8, 2025
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted the PR title as per https://www.notion.so/safe-global/How-to-name-pull-requests-fd1c28aa83544239a02f47d1936adc0d
Nice work!

Looks like lint and tests are failing though.

@Jonathansoufer Jonathansoufer changed the title Fix(Mobile): fix a tabNavigation issue fix: allow tabNavigation to transactions page Jan 8, 2025
@Jonathansoufer Jonathansoufer force-pushed the fix/tab-navigation-issue branch from e2a7c41 to 1fc09cd Compare January 8, 2025 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants