-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(Mobile): Account Management: Edit and reorganise accounts #4721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! Storybook: |
Coverage (56%)
|
apps/mobile/src/features/Assets/components/Balance/Balance.container.tsx
Outdated
Show resolved
Hide resolved
Jonathansoufer
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Left some small comms and doubts only.
1000e25
to
8457c50
Compare
…duplicated source of truth and better and domain centralization
8457c50
to
4161151
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
It enables safe users to edit and reorganise accounts inside the app. Please notice the accounts we have in the app are all fixed accounts because we still do not have the "Add account" functionality working.
Ps: Please notice that in the sortable we have a small re-render issue, this is happening due to the version of
react-native-reanimated
in'react-native-draggable-flatlist'
. Current they supports only react-native-reanimated 2 which is not being used and suported in react native new architecture (76). This might be fixed in this PR: computerjazz/react-native-draggable-flatlist#550.I'm covering the hooks with unit tests, they will come in a separated PR though.
Video
mobile.mp4
Checklist