-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(Mobile): move merged app repo changes #4709
Open
clovisdasilvaneto
wants to merge
5
commits into
dev
Choose a base branch
from
feat/migration
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! Storybook: |
Coverage (50%)
|
katspaugh
changed the title
Feat: move merged app repo changes
Feat(Mobile): move merged app repo changes
Dec 24, 2024
katspaugh
approved these changes
Dec 24, 2024
3 tasks
clovisdasilvaneto
force-pushed
the
feat/migration
branch
from
December 24, 2024 11:14
aeb942e
to
d2439c2
Compare
* docs: move contributing to code-style The contributing doc is actually a code-style doc. Once we move everything to monorepo we will adopt the safe-wallet-web CONTRIBUTING.md file. * docs: add release procedure docs (cherry picked from commit 01345f0)
* feat: add necessary libraries * feat: create useSign hook * feat: cover sign hook with unit tests * Update apps/mobile/src/hooks/useSign/useSign.ts Co-authored-by: katspaugh <[email protected]> * fix: adjust type Co-authored-by: katspaugh <[email protected]> * feat: add react-native-quick-crypto back * fix: lint uintGenericArray problem * fix: adjust export style * fix: remove duplicated lines from gitignore * chore: add reference link * fix: typo on useSign unit tests * chore: store iv in the keychain * Update apps/mobile/src/hooks/useSign/useSign.ts Co-authored-by: Usame Algan <[email protected]> * fix: typo in unit tests --------- Co-authored-by: katspaugh <[email protected]> Co-authored-by: Usame Algan <[email protected]> (cherry picked from commit 45e82f7)
* feat: create useSign hook * feat: add react-native-quick-crypto back * feat: create chainsDisplay component to show the grouped chains images * chore: move redux provider to the top of the react three to make the bottomSheet provider able to read values from redux selectors * feat: create badge variant for using the badge component in the chainsDisplay component according to figma * feat: add testIDs in the chainsDisplay component * feat: allow user to provider a footer to the dropdown component * chore: make the logo size dynamically * feat: create AccountCard component * feat: create AccountItem component to handle the dropdown events and specific layout * feat: replace the image component by the chainsDisplay component in the Balances component * feat: change the color of the active chain in the chain selection dropdown * feat: create a footer for MyAccounts dropdown * feat: remove unnecessary tests * feat: add accounts management feature inside the navbar dropdown * feat: create useInfiniteScroll hook to handle infinite scroll functionality * feat: use activeChain information into the tokens container * feat: make the Identicon component to be more extensible * feat: add mocked constants inside the store folder * feat: create safes slice to store all safes added into the app * feat: add possibility to get all supported chains ids and get them also by id * chore: auto generated types * chore: remove unused types * feat: create MyAccounts container * feat: use isFetching instead isLoading to avoid cached result while query is being revalidated * chore: memoize the chains manipulation in the chainsDisplay component * chore: create an useMyAccountsService hook to handle pos-fetch logic outside the container (cherry picked from commit be1a137b30984b8fcc866fd6767824f5f67ec659)
clovisdasilvaneto
force-pushed
the
feat/migration
branch
from
December 24, 2024 11:16
d2439c2
to
169c024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
This PR moves the last changes which were already reviewed and merged in the app but weren't in the monorepo yet. Bellow are the links of the merged PRs:
https://github.com/safe-global/safe-wallet-mobile/pull/53
https://github.com/safe-global/safe-wallet-mobile/pull/59
https://github.com/safe-global/safe-wallet-mobile/pull/60