Release 1.48.1 #4688
Release 1.48.1 #4688
Conversation
* fix: natively support clear signing with Ledger * Use correct type * Enable typed data signing support * Fix module resolution imports * Remove Jest setup * Update packages * Fix type issues * Fix insufficient funds bug * Update comment * Facilitate toggling module * Fix lock file * Remove logs * Get instead of converting to bytes * Build ethers rejection error from error code * Remove log
* Fix: add chain check in Delete Tx modal * Fix: increase network selector width
Branch preview✅ Deploy successful! Website: Storybook: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -559,6 +555,8 @@ export const dispatchBatchExecutionRelay = async ( | |||
| to, | |||
| data, | |||
| version: safeVersion, | |||
| // We have no estimation in place | |||
| gasLimit: undefined, | |||
| }) | |||
| } catch (error) { | |||
| txs.forEach(({ txId }) => { | |||
There was a problem hiding this comment.
Avoid setting gasLimit to undefined without context. If the estimation is unavailable, consider implementing a fallback mechanism or logging to track missing estimations. This prevents unexpected behavior or failures in transaction execution.
| @@ -13,7 +13,7 @@ | |||
| "noEmit": true, | |||
| "esModuleInterop": true, | |||
| "module": "esnext", | |||
| "moduleResolution": "node", | |||
| "moduleResolution": "Bundler", | |||
| "resolveJsonModule": true, | |||
| "isolatedModules": true, | |||
| "jsx": "preserve", | |||
There was a problem hiding this comment.
Changing moduleResolution to "Bundler" might affect compatibility. Ensure the build tool supports this setting. Consider keeping "node" for broader compatibility unless specific reasons are documented.
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1016.42 KB (🟡 +6.17 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Eleven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/apps |
33.25 KB (🟡 +3.51 KB) |
1.03 MB |
/apps/custom |
31.3 KB (🟡 +3.51 KB) |
1.02 MB |
/apps/open |
53.64 KB (🟡 +3.51 KB) |
1.04 MB |
/home |
58.7 KB (🟡 +3.51 KB) |
1.05 MB |
/settings/safe-apps |
17.82 KB (🟡 +3.51 KB) |
1.01 MB |
/transactions |
96.88 KB (🟡 +3.73 KB) |
1.09 MB |
/transactions/history |
96.84 KB (🟡 +3.73 KB) |
1.09 MB |
/transactions/messages |
58.4 KB (🟡 +3.51 KB) |
1.05 MB |
/transactions/msg |
54.55 KB (🟡 +3.51 KB) |
1.05 MB |
/transactions/queue |
47.51 KB (🟡 +3.51 KB) |
1.04 MB |
/transactions/tx |
46.78 KB (🟡 +3.51 KB) |
1.04 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Test suite run success1715 tests passing in 233 suites. Report generated by 🧪jest coverage report action from bc20acb |
|
Verified |
gasLimit(fix: always estimate relaygasLimit#4679)